1664047 - Unnecessary GPU usage during compositing from profiler screenshots code even if the profiler is off

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Markus Stange [:mstange]]

This is a regression from bug 1592031: We call UpdateSnapshot even when the profiler is off, which causes unnecessary extra CPU and GPU work on each composite on macOS+WR. We only need to call UpdateSnapshot if the profiler is running and the Screenshots profiler setting is enabled.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1592031

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1664047 - Only call UpdateSnapshot when ScreenshotGrabber calls GetWindowContents, which it only does if the profiler is running (and Screenshots are enabled). r=mattwoodrow

This requires passing down the window size down in a different way, because the
NativeLayerRootSnapshotter does not know the window size otherwise.

At the same time, this patch also removes WindowNLRS and makes the NativeLayerRoot
implement the profiler_screenshots::Window interface directly.

Depends on D89863

Comment 3

[Markus Stange [:mstange]]

[Tracking Requested - why for this release]: Regression that affects WR perf. WR will ride the train to most Mac users in 82 on release (bug 1654271).

Comment 4

[Julien Cristau [:jcristau]]

Thanks Markus.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8996fcd3568
Only call UpdateSnapshot when ScreenshotGrabber calls GetWindowContents, which it only does if the profiler is running (and Screenshots are enabled). r=mattwoodrow

Comment 6

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1664047, Bug 1664135) for causing dt failures in ScreenshotGrabber.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/b91bf98042fa3896bc60ace988b2c3ce1fbd29c7

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=windows%2C10%2Cx64%2Copt%2Cmochitests%2Ctest-windows10-64%2Fopt-mochitest-devtools-chrome-e10s%2Cdt5&tochange=b91bf98042fa3896bc60ace988b2c3ce1fbd29c7&fromchange=8c8f6d93ade332edc31bba40a8bddb6aab1ef963

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315689337&repo=autoland&lineNumber=7490

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36693e01331a
Only call UpdateSnapshot when ScreenshotGrabber calls GetWindowContents, which it only does if the profiler is running (and Screenshots are enabled). r=mattwoodrow

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/36693e01331a