1664065 - Heartbeat: Notifications in dark theme are unreadable

Status: RESOLVED FIXED

(Firefox :: Normandy Client, defect, P1)

Description

[Kamyar Ardekani (he/him)]

Attachment: Heartbeat notification

Heartbeat notifications have a white text on a light background that make them unreadable (see screenshot). This is not an issue in Firefox 79.

Steps to produce:

1. Download and install the Normandy devtools extension
2. Run one of the Heartbeat recipes
3. See that the notification is not readable.

Comment 1

[Rosanne Scholl]

We have paused all Heartbeat messages until this is fixed, making it critical for quant UR.

Comment 2

[Michael Cooper [:mythmon]]

Attachment: image.png

I can't reproduce this on Firefox 80 Release on Linux.

Comment 3

[Rosanne Scholl]

I experienced this in Nightly 82 on MacOS 10.14.6.

Comment 4

[Michael Cooper [:mythmon]]

We were able to track down the regression range, which pointed solidly at bug 1656494.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://searchfox.org/mozilla-central/rev/eb9d5c97927aea75f0c8e38bbc5b5d288099e687/toolkit/components/normandy/skin/osx/Heartbeat.css#7 looks to be the actual source of the problem, though bug 1656494 made this an issue. Why does Heartbeat force a white background gradient?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1664065 - Remove Heartbeat specific styling since Firefox now shows notification bars in the same dimensions that Heartbeat wanted.

Comment 7

[Michael Cooper [:mythmon]]

Why does Heartbeat force a white background gradient?

The answer to this question is lost to time, probably a time before we had browser wide dark mode. We don't need this anymore, and can go with the standard styles now.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1656494

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e55c0eadc7e
Remove Heartbeat specific styling since Firefox now shows notification bars in the same dimensions that Heartbeat wanted. r=Gijs

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5e55c0eadc7e

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jaws, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9175026 [details]
Bug 1664065 - Remove Heartbeat specific styling since Firefox now shows notification bars in the same dimensions that Heartbeat wanted.

Beta/Release Uplift Approval Request

• User impact if declined: Users will be unable to read the heartbeat notifications due to extremely low contrast.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Removal of CSS that is no longer necessary now that all notification bars are larger.
• String changes made/needed: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9175026 [details]
Bug 1664065 - Remove Heartbeat specific styling since Firefox now shows notification bars in the same dimensions that Heartbeat wanted.

Approved for 81.0rc1.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dd54cd968e97