1664077 - Remove _NON_GLOBAL_ACDEFINES

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Mike Hommey [:glandium]]

I think they're remnants from the past that we don't really need anymore. And they're making things more complicated for some pending work of mine.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1664077 - Remove _NON_GLOBAL_ACDEFINES.

I think they're remnants from the past that we don't really need anymore.
And they're making things more complicated for some pending work of mine.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee6dbeaf8852
Remove _NON_GLOBAL_ACDEFINES. r=firefox-build-system-reviewers,mhentges,rstewart

Comment 3

[Razvan Maries]

Backed out for build bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=PELVRyDlT-Ktk59-mMUrkQ.1&resultStatus=testfailed%2Cbusted%2Cexception&revision=ee6dbeaf885296d2b9883a1e148fe4f4032633de&failure_classification_id=2

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315698396&repo=autoland&lineNumber=15294

Backout: https://hg.mozilla.org/integration/autoland/rev/2e9bfe12da5a4c2c1e9087392390fcdf700fc003

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1664077 - Move statvfs-related defines from nsLocalFileUnix.h to .cpp.

They are not needed anywhere else than the .cpp, and can cause problems
from the additional includes they pull.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1664077 - Remove xpcom-private.h.

It's not necessary anymore.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61d0dcad173e
Move statvfs-related defines from nsLocalFileUnix.h to .cpp. r=sg
https://hg.mozilla.org/integration/autoland/rev/09dd05b4d15c
Remove _NON_GLOBAL_ACDEFINES. r=firefox-build-system-reviewers,mhentges,rstewart
https://hg.mozilla.org/integration/autoland/rev/5297fcec7cd7
Remove xpcom-private.h. r=sg

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/61d0dcad173e
https://hg.mozilla.org/mozilla-central/rev/09dd05b4d15c
https://hg.mozilla.org/mozilla-central/rev/5297fcec7cd7