1664086 - Use Fluent to set aria-label for credit card list options in preferences

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect)

Description

[James Teh [:Jamie]]

In bug 1662879 D89548, aria-label is manually set for options in the credit cards list in preferences after Fluent translation for the option has completed. As noted in this comment:

So, the problem you're facing here is that what you wrote is not ready to react to locale changes during the document's life cycle.
If the element gets retranslated to a new locale, the aria-label will stay with the old one.

I didn't fix this in that patch because a proper fix would have required a new Fluent string, which we can't do there because we need to uplift it to 81. Alternatively, we could have used a MutationObserver, but that's pretty intense and isn't really the right solution anyway.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1664086: Use Fluent to set aria-label for credit card list options in preferences.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65196da3227e
Use Fluent to set aria-label for credit card list options in preferences. r=zbraniecki,fluent-reviewers

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/65196da3227e