1664122 - Improve MarkerOptions accessors

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

MarkerOptions::Set() works on any non-const object, and always returns an rvalue reference, it doesn't feel right! Instead we should have the same reference type as input and output.

MarkerOptions::NAME() returns a reference to member on both const and non-const objects, I think it'd be better to reserve NAME() to get a const reference, and have an explicit NAMERef() when non-const access is needed.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1664122 - Clearer MarkerOptions accessors - r?gregtatum

MarkerOptions::Set() returns the same reference type as the object it's invoked on, i.e.: & -> &, and && -> &&.

MarkerOptions::NAME() always returns a reference to a const member, so it's clear it cannot be modified (even if the object at hand is not const).
MarkerOptions::NAMERef() can now be used when non-const access is needed.

Depends on D89588

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e381cc96a788
Clearer MarkerOptions accessors - r=gregtatum

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e381cc96a788