1664143 - Introduce ExecuteSimpleSQLSequence helper function

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task)

Description

[Simon Giesecke [:sg] [he/him]]

A nsresult ExecuteSimpleSQLSequence(mozIStorageConnection& aConnection, Span<const nsLiteralCString> aSQLCommands) helper function could be used to execute a sequence of SQL statements, instead of having individual calls to ExecuteSImpleSQL. This would make the code more straightforward and smaller.

However, we should ensure that failures of an individual SQL statement are properly logged. See also discussion in https://phabricator.services.mozilla.com/D89617#inline-508627

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1664143 - Use IDB_TRY in Create*Tables and use a ExecuteSimpleSQLSequence helper function. r=#dom-workers-and-storage

Comment 2

[Simon Giesecke [:sg] [he/him]]

For ExecuteCachedStatement a similar thing should be done.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cfe3f985d90
Use IDB_TRY in Create*Tables and use a ExecuteSimpleSQLSequence helper function. r=dom-workers-and-storage-reviewers,janv

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2cfe3f985d90