1664192 - Turn on spocs by default in DE

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

This is a pref flip. Should be super easy.

Likely we want this uplifted into 81 RC.

We've run this on release as an experiment already, and was waiting for vp signoff.

Similar to what we did with bug 1650200

Comment 1

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]:

Comment 2

[Jessilyn Davis]

Aiming for VP signoff by EOD today (9/10) in time for Beta build on Friday, or RC build for Monday.

Comment 3

[Scott [:thecount] Downe]

Attachment: Bug 1664192 - Newtab spocs in DE

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 9175040 [details]
Bug 1664192 - Newtab spocs in DE

Beta/Release Uplift Approval Request

• User impact if declined: Non, revenue impact though.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. from a new profile, set browser.search.region to DE

2. set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
3. Go through the steps here to enable the de langpack https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/v2-system-addon/geo_locale.html#setting-custom-geo-locale-and-update-channels
4. Set browser.newtabpage.activity-stream.discoverystream.spocs-endpoint to "https://spocs.getpocket.com/spocs?country=US&region=CA"
5. Restart
6. go to about:home#devtools-ds and click "refresh cache"
7. Go to a newtab

Expected: There should be an English spoc in the DE browser, in the third position. Ignore the fact that it's in English. We're forcing an English spoc for QA purposes to produce more consistent test results. Because of pacing, doing this with German spocs are likely to produce no results, making QA quite impossible. If you want to try, use "https://spocs.getpocket.com/spocs?country=DE" in step 4, you may see a German language spoc, you may not. You can also verify spocs are on by going to about:newtab#devtools-ds and ensuring the "show_spocs" checkbox is checked.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's just a single pref change for a value that's already been set to true from most of release already via experiments/rollouts.
• String changes made/needed: none

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/410924762094
Newtab spocs in DE r=gvn

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/410924762094

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9175040 [details]
Bug 1664192 - Newtab spocs in DE

Approved for 81.0rc1.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/35e8a6b9e7ed

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

The work on this enhancement was part of the work done on PI-800. Considering this I am changing the status to Verified.