Closed Bug 1664215 Opened 4 years ago Closed 4 years ago

PDF_VIEWER_FALLBACK_REASON should specify that it is only collected in content processes

Categories

(Firefox :: PDF Viewer, defect)

defect

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: wlach, Assigned: wlach)

References

Details

Attachments

(1 file)

Currently it claims to be collected in the main process, but telemetry indicates it is only recorded in the content process.

https://searchfox.org/mozilla-central/rev/8a0745cd346f0cfb89ae71690babbf7bff706113/toolkit/components/telemetry/Histograms.json#9401

This can cause confusion:

https://mozilla.slack.com/archives/C4D5ZA91B/p1599738740069900

BTW, it looks like there are a number of pdf.js probes that are content only, but marked as both.

Out of curiosity, why do we distinguish between content/main?

Pushed by wlachance@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1cfbdaba6d16
Specify that PDF_VIEWER_FALLBACK_REASON is only collected in content processes r=bdahl,chutten

(In reply to Brendan Dahl [:bdahl] from comment #2)

BTW, it looks like there are a number of pdf.js probes that are content only, but marked as both.

Oh! If you could file a follow-up bug for those that would be good.

Out of curiosity, why do we distinguish between content/main?

:chutten may be able to say more, but my understanding is that some probes genuinely are accumulated in both the content and main process, and it's useful to distinguish them when doing analysis.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: