1664227 - The default page margin should be at least the unwriteable section, but not added on top.

Status: RESOLVED FIXED

(Core :: Printing: Setup, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1664227 - Remove some useless nullchecks in nsPageFrame.cpp. r=jwatt,bobowen

They're dereferenced without checking below, so checking here is just
confusing.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1664227 - Grab the print settings in nsPageSequenceFrame::Init. r=jwatt,bobowen

We should always have sane print settings by then. This avoids other
confusing checks elsewhere.

Depends on D89792

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1664227 - The default page margin should be at least the unwriteable section, but not added on top. r=bobowen,jwatt

We were adding the unwriteable to the default margin. I was going to
consider not painting the headers / footers if they overlapped with the
content box of the page, but turns out our default configuration
overlaps slightly at the bottom, so I just punted on that.

Users can remove the headers / footers quite easily anyhow.

Depends on D89793

Comment 4

[Sam Foster [:sfoster] (he/him)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

We should always have sane print settings by then. This avoids other
confusing checks elsewhere.

Am I right in thinking that the settings for a given printer should be the source of truth for default margin values?
On the front-end, we currently get these these from the default settings (printer.createDefaultSettings(printerName)) - as distinct from the regular settings which have the user pref values merged into them.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

(In reply to Sam Foster [:sfoster] (he/him) from comment #4)

Am I right in thinking that the settings for a given printer should be the source of truth for default margin values?
On the front-end, we currently get these these from the default settings (printer.createDefaultSettings(printerName)) - as distinct from the regular settings which have the user pref values merged into them.

Yes, I think that's fair to say (though I think that we have some bugs on the area). Anyhow what the actual settings are is a bit unrelated to that patch :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21ec1a46de89
Remove some useless nullchecks in nsPageFrame.cpp. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/bfb181efe0f2
Grab the print settings in nsPageSequenceFrame::Init. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/19383932e3bf
The default page margin should be at least the unwriteable section, but not added on top. r=jwatt

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/21ec1a46de89
https://hg.mozilla.org/mozilla-central/rev/bfb181efe0f2
https://hg.mozilla.org/mozilla-central/rev/19383932e3bf