Last Comment Bug 166426 - Move FROZEN ContractID into nsXPCOM.h and define
: Move FROZEN ContractID into nsXPCOM.h and define
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: x86 Windows 2000
: -- normal (vote)
: ---
Assigned To: Doug Turner (:dougt)
: Scott Collins
: Nathan Froyd [:froydnj]
Depends on:
  Show dependency treegraph
Reported: 2002-09-03 13:47 PDT by Doug Turner (:dougt)
Modified: 2002-09-03 17:21 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

suggested patch v.1 (3.26 KB, patch)
2002-09-03 13:58 PDT, Doug Turner (:dougt)
no flags Details | Diff | Splinter Review
patch 2 (26.65 KB, patch)
2002-09-03 14:54 PDT, Doug Turner (:dougt)
rpotts: review+
Details | Diff | Splinter Review

Description Doug Turner (:dougt) 2002-09-03 13:47:28 PDT
nsICategoryManager nsIProperties nsIDirectoryService have contract ID's in their
IDLS.  Lets move them into a header.
Comment 1 Doug Turner (:dougt) 2002-09-03 13:58:31 PDT
Created attachment 97651 [details] [diff] [review]
suggested patch v.1
Comment 2 Doug Turner (:dougt) 2002-09-03 14:54:01 PDT
Created attachment 97671 [details] [diff] [review]
patch 2

this also includes alecf's work on the primative types.
Comment 3 Doug Turner (:dougt) 2002-09-03 14:55:09 PDT
Comment on attachment 97671 [details] [diff] [review]
patch 2

ignore the change to io/nsLocalFileWin.cpp
Comment 4 Alec Flett 2002-09-03 15:31:50 PDT
Comment on attachment 97671 [details] [diff] [review]
patch 2

is that nsLocalFileWin stuff supposed to be in there?

other than that, sr=alecf

I wonder if we should split some of these up into smaller files - nsXPCOM.h
seems like its just going to get huge!
Comment 5 rpotts (gone) 2002-09-03 15:37:23 PDT
Comment on attachment 97671 [details] [diff] [review]
patch 2

i'd 'prefer' that the component definitions lived in their own file :-)  but
this is ok...

-- rick
Comment 6 Doug Turner (:dougt) 2002-09-03 17:21:31 PDT
fixed on trunk.  does this need to be fixed on the branch?  I pray not.

Note You need to log in before you can comment on or make changes to this bug.