Closed
Bug 166426
Opened 23 years ago
Closed 23 years ago
Move FROZEN ContractID into nsXPCOM.h and define
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file, 1 obsolete file)
|
26.65 KB,
patch
|
rpotts
:
review+
|
Details | Diff | Splinter Review |
nsICategoryManager nsIProperties nsIDirectoryService have contract ID's in their
IDLS. Lets move them into a header.
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Comment 2•23 years ago
|
||
this also includes alecf's work on the primative types.
Attachment #97651 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•23 years ago
|
||
Comment on attachment 97671 [details] [diff] [review]
patch 2
ignore the change to io/nsLocalFileWin.cpp
|
||
Comment 4•23 years ago
|
||
Comment on attachment 97671 [details] [diff] [review]
patch 2
is that nsLocalFileWin stuff supposed to be in there?
other than that, sr=alecf
I wonder if we should split some of these up into smaller files - nsXPCOM.h
seems like its just going to get huge!
Attachment #97671 -
Flags: superreview+
|
||
Comment 5•23 years ago
|
||
Comment on attachment 97671 [details] [diff] [review]
patch 2
i'd 'prefer' that the component definitions lived in their own file :-) but
this is ok...
-- rick
Attachment #97671 -
Flags: superreview+ → review+
|
|
Assignee | |
Comment 6•23 years ago
|
||
fixed on trunk. does this need to be fixed on the branch? I pray not.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•