1664291 - Disable credit card autofill in 81 Beta

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, task, P2)

Description

[Jim Mathies [:jimm]]

The shipping decision is still TBD, but in case the decision is made to not ship, filing this bug and getting the patches ready for beta to flip the prefs.

Comment 1

[Jim Mathies [:jimm]]

Attachment: Bug 1664291 - Disable credit card autofill in Fx 81. r=zbraniecki

Comment 2

[Jim Mathies [:jimm]]

I have one more patch coming up that will restrict cc autofill to Nightly builds.

Comment 3

[Jim Mathies [:jimm]]

Attachment: Bug 1664291 - Restrict credit card auotfill to Nightly builds. r=zbraniecki

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 9175233 [details]
Bug 1664291 - Disable credit card autofill in Fx 81. r=zbraniecki

Beta/Release Uplift Approval Request

• User impact if declined: Per Firefox org decision, we're pulling this feature from 81.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Check to make sure credit card autofill does not display in content or through preferences.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple pref flip. There's some risk in that we've been running with the feature throughout beta, so we should do a little testing to be sure nothing weird shows up.
• String changes made/needed: none

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57d67cd71e22
Restrict credit card auotfill to Nightly builds. r=zbraniecki

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/57d67cd71e22

Comment 7

[Ciprian Georgiu, Desktop QA]

I have checked that this patch doesn't affected Nightly builds 82.0a1 (20200914095101), the credit card autofill still works as expected, and the pref extensions.formautofill.creditCards.available is set on true by default.

I'm not going to remove the qe+ flag for now, in case this gets a chance to be uplifted in 81 RC.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9175233 [details]
Bug 1664291 - Disable credit card autofill in Fx 81. r=zbraniecki

Approved for 81.0rc1.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)

Approved for 81.0rc1.

We ran out of time to deal with the CI fallout from disabling this feature, so I'm going to go ahead and build RC1 w/o this change included. I'm going to need to build an RC2 later this week and will include it then. In the mean time, I'll get a Try build created so QA can at last do their testing with a build which more closely resembles the shipping configuration.

Comment 10

[Alin Ilea, Desktop Test Engineering]

Hi,
I tested this using the Try build and it seems to work accordingly. The CC feature is disabled by default and it works properly if I enable it by changing the CC pref to true.
Thanks.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/0dd3bc9d279e