1664293 - Add frontend::CompileLazyFunctionToStencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

Incremental encoding needs to support XDR encode stencil for lazy functions

https://searchfox.org/mozilla-central/rev/eb9d5c97927aea75f0c8e38bbc5b5d288099e687/js/src/vm/JSFunction.cpp#1588-1629

static bool DelazifyCanonicalScriptedFunction(JSContext* cx,
                                              HandleFunction fun) {
...
  {
...
    if (ss->hasSourceType<Utf8Unit>()) {
...
      if (!frontend::CompileLazyFunction(cx, lazy, units.get(), sourceLength)) {
        // The frontend shouldn't fail after linking the function and the
        // non-lazy script together.
        MOZ_ASSERT(fun->baseScript() == lazy);
        MOZ_ASSERT(lazy->isReadyForDelazification());
        return false;
      }
    } else {
...
      if (!frontend::CompileLazyFunction(cx, lazy, units.get(), sourceLength)) {
        // The frontend shouldn't fail after linking the function and the
        // non-lazy script together.
        MOZ_ASSERT(fun->baseScript() == lazy);
        MOZ_ASSERT(lazy->isReadyForDelazification());
        return false;
      }
    }
  }
...
  // XDR the newly delazified function.
  if (ss->hasEncoder()) {
    RootedScriptSourceObject sourceObject(cx, script->sourceObject());
    if (!ss->xdrEncodeFunction(cx, fun, sourceObject)) {
      return false;
    }
  }

  return true;
}

that callsite needs to be replaced with:

• frontend::CompileLazyFunctionToStencil
frontend::CompileLazyFunction without instantiateStencils
• frontend::InstantiateFunctionStencils
  almost same as frontend::InstantiateStencils, but for function

So that it can receive stencil and encode it there instead.

Comment 1

[Tooru Fujisawa [:arai]]

the above is the only consumer of frontend::CompileLazyFunction, so we can replace frontend::CompileLazyFunction with stencil APIs

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1664293 - Part 1: Templatize DelazifyCanonicalScriptedFunction for char unit. r?tcampbell!

Depends on D89898

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1664293 - Part 2: Replace frontend::CompileLazyFunction with frontend::CompileLazyFunctionToStencil + frontend::InstantiateStencilsForDelazify. r?tcampbell!

Depends on D89899

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a38622e0d603
Part 1: Templatize DelazifyCanonicalScriptedFunction for char unit. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e5ce23073da5
Part 2: Replace frontend::CompileLazyFunction with frontend::CompileLazyFunctionToStencil + frontend::InstantiateStencilsForDelazify. r=tcampbell

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a38622e0d603
https://hg.mozilla.org/mozilla-central/rev/e5ce23073da5