Closed Bug 1664327 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25476 - [css-flex] Fix flex basis for some aspect ratio items

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25476 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25476
Details from upstream follow.

b'David Grogan <dgrogan@chromium.org>' wrote:

[css-flex] Fix flex basis for some aspect ratio items

Flex previously obeyed the computed min/max-width when determining flex
base size for aspect ratio items in row flexboxes, when it was supposed
to be using 'max-content'.

We also weren't returning available size as the max-content size of an
SVG item that only has an aspect ratio and no intrinsic sizes, which is
what Firefox does and what the spec dictates.

Both of these are fixed with a new aspect-ratio sizing method that
currently lives in flex but will be moved to NGReplacedLayoutAlgorithm
when it exists.

Change-Id: I4afb382a7604a4fcd0626f0702edf72f21cd0bcc
Bug: 987000
Reviewed-on: https://chromium-review.googlesource.com/2399082
WPT-Export-Revision: b591afed2cd02a9e4b8ecaf99c66ccdb7767c459

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests

Status Summary

Firefox

PASS: 5
FAIL: 2

Chrome

PASS: 4
FAIL: 3

Safari

PASS: 1
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-flexbox/flex-aspect-ratio-img-row-008.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-flexbox/flex-aspect-ratio-img-row-009.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ef1409d725d
[wpt PR 25476] - [css-flex] Fix flex base size for some aspect ratio items, a=testonly
https://hg.mozilla.org/integration/autoland/rev/72d83ee2f409
[wpt PR 25476] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7ef1409d725d
https://hg.mozilla.org/mozilla-central/rev/72d83ee2f409

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.