1664402 - Amazon.de gets migrated into amazon.com after succesive browser.topsites.useRemoteSetting on/off switches

Status: VERIFIED FIXED

(Firefox :: Top Sites, defect, P1)

Description

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

[Sugested Severity:]
S2

[Description:]
Switching the browser.topsites.useRemoteSetting on/off/on, it is possible to alter the default topsite amazon.de into amazon.com.

Additionally, probably after the bug 1661008 fix, amazon.com also gets pinned by default and marked as a search shortcut. (this part is not reproducible on 81 b4)

[Environment:]
Windows 10, Ubuntu 20, Mac 10.13.6
81.0b9

[Steps:]

1. Create a new profile with:
   user_pref("services.settings.load_dump", false);
   user_pref("browser.topsites.useRemoteSetting", true);
   user_pref("browser.search.region", "DE");
2. Start Firefox, observe topsites -> from RS top-sites collection.
3. Close Firefox, set browser.topsites.useRemoteSetting to false.
4. Start Firefox, observe topsites -> legacy configuration.
5. Close Firefox, set browser.topsites.useRemoteSetting to true.
6. Start Firefox, observe topsites -> from RS top-sites collection.

[Actual Result:]

2. (RS)amazon.de is listed, not pinned, not search shortcut
3. (legacy)amazon.com is listed, pinned, search shortcut.
4. (RS)amazon.com is listed, pinned, search shortcut.

[Expected Result:]

2. (RS)amazon.de is listed, not pinned, not search shortcut
3. (legacy)amazon.com is listed, pinned, search shortcut.
4. (RS)amazon.de is listed, not pinned, not search shortcut.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1664402 - Support migrating browser.topsites.useRemoteSetting true to false and back to true. r=mikedeboer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b76c123c607d
Support migrating browser.topsites.useRemoteSetting true to false and back to true. r=mikedeboer

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 9175150 [details]
Bug 1664402 - Support migrating browser.topsites.useRemoteSetting true to false and back to true. r=mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: We don't plan on switching browser.topsites.useRemoteSetting on and off and back on, but it's good to have this fix in place for users doing so manually for whatever reason. This also fixes the karma issue filed as bug 1664288.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed:

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b76c123c607d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9175150 [details]
Bug 1664402 - Support migrating browser.topsites.useRemoteSetting true to false and back to true. r=mikedeboer

Approved for 81.0rc1.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ef1fb730d1a

Comment 7

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

This bug was verified during the PI-763 test run, but in light of latest fixes and uplifts, reverified it and comment 0 STR now work as expected on both nightly 82.0a1 2020-09-16 and 81 RC1.