Closed
Bug 1664412
Opened 4 years ago
Closed 4 years ago
Reduce the impact of QM_TRY* error handling on code size
Categories
(Core :: Storage: Quota Manager, task)
Core
Storage: Quota Manager
Tracking
()
RESOLVED
FIXED
82 Branch
Tracking | Status | |
---|---|---|
firefox82 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
Details
Attachments
(1 file)
In early-beta-or-earlier (or debug) builds, the error reporting done via QM_TRY*
macros is complex but rarely executed, so it makes sense to make the functions as MOZ_COLD
.
In late-beta-or-release builds, the error reporting is turned off, so the error handling function is empty and should always be inlined.
We should use that knowledge to minimize the impact of the use of the macros on code size.
Assignee | ||
Comment 1•4 years ago
|
||
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b806f8344f0 Mark some error handling functions as MOZ_COLD. r=dom-workers-and-storage-reviewers,janv
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•