1664437 - Extract Window global logger to dedicated module

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

We have a development helper to log window globals used from both the frame-helper and the JsWindowActor DevToolsFrameChild:

• https://searchfox.org/mozilla-central/rev/eb9d5c97927aea75f0c8e38bbc5b5d288099e687/devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm#96
• https://searchfox.org/mozilla-central/rev/eb9d5c97927aea75f0c8e38bbc5b5d288099e687/devtools/server/actors/watcher/target-helpers/frame-helper.js#295

Since it was introduced, a few things seem to have changed (eg the uri is no longer accessible via the same path). We could move it to a dedicated file.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1664437 - Extract DevTools WindowGlobalLogger to a dedicated module

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1664437 - Update WindowGlobalLogger to format logs on several lines

Depends on D89908

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1664437 - Fix uri logging in WindowGlobalLogger

Depends on D89909

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ff2258094f8
Extract DevTools WindowGlobalLogger to a dedicated module r=ochameau
https://hg.mozilla.org/integration/autoland/rev/98e838e65257
Update WindowGlobalLogger to format logs on several lines r=ochameau
https://hg.mozilla.org/integration/autoland/rev/40f92c48e485
Fix uri logging in WindowGlobalLogger r=ochameau

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1ff2258094f8
https://hg.mozilla.org/mozilla-central/rev/98e838e65257
https://hg.mozilla.org/mozilla-central/rev/40f92c48e485