1664459 - Simplify WebRender radial gradient shader

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Lee Salzman [:lsalzman]]

It looks like the radial gradient shader bit-rotted ages ago due to https://github.com/servo/webrender/issues/2439 and subsequent commit https://github.com/servo/webrender/commit/54d0f7f0fe2b70cd023609cf814db8e0c47c9a7b

We don't need to solve a full quadratic anymore and this shader can be massively simplified to both remove the quadratic equation and the discard.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1664459 - simplify WebRender radial gradient shader. r?mattwoodrow

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83968b707429
simplify WebRender radial gradient shader. r=mattwoodrow

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for reftest failures on border-image-radial-gradient-width.html

backout: https://hg.mozilla.org/integration/autoland/rev/afe57316eb685d45f40f900ff920bf652f978b93

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=83968b7074290fac064e9c88249814340dd3c708&group_state=expanded&selectedTaskRun=StzpYV9LT2GJLDlkUh0y4A.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315537488&repo=autoland&lineNumber=23379

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3f95f66b7de
simplify WebRender radial gradient shader. r=mattwoodrow

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for reftest failures on border-image-radial-gradient-width.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/86ac1db905b58619a95a8a3d1dfd417f29468ab5
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315569433&repo=autoland&lineNumber=41553

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85e23b4d97ac
simplify WebRender radial gradient shader. r=mattwoodrow

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/85e23b4d97ac