Closed Bug 1664461 Opened 6 months ago Closed 5 months ago

Add instrumentation and fog-validation ping to FOG

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: chutten, Assigned: chutten)

References

Details

(Whiteboard: [telemetry:fog:m6])

Attachments

(5 files)

bug 1658359 had lofty goals, not all of which were completed. This is a follow-up bug to deal with:

  • Instrument all the errors in FOG that we can find. Anything whose error results we've been silently eating or logging. And maybe some other error results we pass on to the callers as well.
  • Schedule and send a "fog-validation" ping regularly (even when there's no errors to send)
    • The FOGotype sent it every hour, so we can ape that
    • If you couldn't tell from the name, this is a temporary ping. Later we'll be sending these errors on some other ping (maybe a "metrics" ping if we have one of those, maybe a dedicated "fog-health" ping we'll send only when there's something to send)
  • Data Review
Blocks: 1651110
Assignee: nobody → chutten
Status: NEW → ASSIGNED
Priority: P3 → P1

Depends on D92470

Attachment #9179675 - Flags: data-review?(jennyzhang)
Attachment #9179680 - Flags: data-review?(jennyzhang)

Comment on attachment 9179675 [details]
data collection review - IPC Replay Errors

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :chutten will be monitoring this data.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1.

Is the data collection request for default-on or default-off?

Default on for all channels if Telemetry is enabled.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No.

Does the data collection use a third-party collection tool? If yes, escalate to legal.

No


Result: datareview+

Attachment #9179675 - Flags: data-review?(jennyzhang) → data-review+

Comment on attachment 9179680 [details]
data collection review - "fog-validation" ping

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, there will be after implementation.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, proposed collection is time-bound.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1 and 2.

Is the data collection request for default-on or default-off?

Default on for all channels if Telemetry is enabled (starting with Nightly).

Does the instrumentation include the addition of any new identifiers?

Yes - it will include a new client_id that doesn't correspond to existing identifiers.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes, by Dec 31 2020.

Does the data collection use a third-party collection tool? If yes, escalate to legal.

No.

--

Result: pending - need to check with legal re: new identifier.

Flags: needinfo?(agray)

Approved by Trust.

Flags: needinfo?(agray)

Comment on attachment 9179680 [details]
data collection review - "fog-validation" ping

Data review passed following approval from Trust.

Attachment #9179680 - Flags: data-review?(jennyzhang) → data-review+
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a0f525277e2
Glean Categories must be snake_case'd for Rust r=janerik
https://hg.mozilla.org/integration/autoland/rev/1f20da3a10f1
Instrument FOG ipc buffer replay failures r=janerik
https://hg.mozilla.org/integration/autoland/rev/f229865f89b6
Send an hourly 'fog-validation' ping r=janerik
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Depends on: 1694466
You need to log in before you can comment on or make changes to this bug.