Closed
Bug 1664482
Opened 4 years ago
Closed 4 years ago
build-sm.sh refers to UPLOAD_DIR before it is created
Categories
(Firefox Build System :: Toolchains, defect)
Firefox Build System
Toolchains
Tracking
(firefox82 fixed)
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: away, Assigned: away)
Details
Attachments
(1 file)
The cd occurs before the mkdir: https://searchfox.org/mozilla-central/rev/eb9d5c97927aea75f0c8e38bbc5b5d288099e687/taskcluster/scripts/builder/build-sm.sh#10-16
Summary: build-sm.sh refers to MOZ_UPLOAD_DIR before it is created → build-sm.sh refers to UPLOAD_DIR before it is created
The script uses the cd $FOO && pwd trick to fix the path style on Windows, but currently this happens before the mkdir, so we get an incorrect result:
[task 2020-09-11T03:38:59.656Z] ++ cd Z:/task_1599794667/public/build
[task 2020-09-11T03:38:59.656Z] ./src/taskcluster/scripts/builder/build-sm.sh: line 10: cd: Z:/task_1599794667/public/build: No such file or directory
[task 2020-09-11T03:38:59.656Z] ++ pwd
[task 2020-09-11T03:38:59.657Z] + export MOZ_UPLOAD_DIR=/z/task_1599794667
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b45c432bf88f Make UPLOAD_DIR before referencing it in build-sm.sh r=froydnj
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•