Closed Bug 1664482 Opened 2 months ago Closed 2 months ago

build-sm.sh refers to UPLOAD_DIR before it is created

Categories

(Firefox Build System :: Toolchains, defect)

defect

Tracking

(firefox82 fixed)

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

Details

Attachments

(1 file)

Summary: build-sm.sh refers to MOZ_UPLOAD_DIR before it is created → build-sm.sh refers to UPLOAD_DIR before it is created

The script uses the cd $FOO && pwd trick to fix the path style on Windows, but currently this happens before the mkdir, so we get an incorrect result:

[task 2020-09-11T03:38:59.656Z] ++ cd Z:/task_1599794667/public/build
[task 2020-09-11T03:38:59.656Z] ./src/taskcluster/scripts/builder/build-sm.sh: line 10: cd: Z:/task_1599794667/public/build: No such file or directory
[task 2020-09-11T03:38:59.656Z] ++ pwd
[task 2020-09-11T03:38:59.657Z] + export MOZ_UPLOAD_DIR=/z/task_1599794667
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b45c432bf88f
Make UPLOAD_DIR before referencing it in build-sm.sh r=froydnj
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.