1664485 - [sanitizer] interop with current, simple tests in wpt

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Frederik Braun [:freddy]]

There are some various wpt test failures, that we need to fix before we can enable the tests to be run in our CI.

This is the behavior we need:

sanitizeToString("") -> returns empty string
sanitizeToString() -> throws, missing argument
sanitizeToString(undefined) -> parses through the Fragment Parsing algorithm as "undefined"

Comment 1

[Frederik Braun [:freddy]]

Attachment: Bug 1664485 - map sanitizer-api folder in wpt to DOM: Security r?jgraham

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a679f29cc976
map sanitizer-api folder in wpt to DOM: Security r=jgraham DONTBUILD

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a679f29cc976

Comment 4

[Frederik Braun [:freddy]]

This is missing a couple of patches, oddly.

Comment 5

[Frederik Braun [:freddy]]

Attachment: Bug 1664485 - Rename Sanitizer API tests to require SecureContext r=jgraham

Comment 6

[Frederik Braun [:freddy]]

Attachment: Bug 1664485 - Adjust Sanitizer API test expectations for SecureContext r=jgraham

Depends on D105741

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ca33c618714
Rename Sanitizer API tests to require SecureContext r=jgraham
https://hg.mozilla.org/integration/autoland/rev/47a8f522b91b
Adjust Sanitizer API test expectations for SecureContext r=jgraham

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27698 for changes under testing/web-platform/tests

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7ca33c618714
https://hg.mozilla.org/mozilla-central/rev/47a8f522b91b

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Frederik Braun [:freddy]]

Attachment: Bug 1664485 - make sanitize/sanitizeToString param's non-optional r?ckerschb

Comment 12

[Frederik Braun [:freddy]]

Attachment: Bug 1664485 - update WPT for optional sanitize arguments r?ckerschb

Depends on D105953

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cffeff2a2803
make sanitize/sanitizeToString param's non-optional r=ckerschb,emilio

Comment 14

[Cosmin Sabou [:CosminS]]

Backed out for wpt sanitizer-api related failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&fromchange=cffeff2a28032c57f5d43a8293814d4cedbbc804&tochange=b422dd886e036907f35269f381f43785873c5296&searchStr=wpt&selectedTaskRun=eXu2s5jZTKOsyC3EDciy2Q.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=330911082&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/b422dd886e036907f35269f381f43785873c5296

Comment 15

[Frederik Braun [:freddy]]

The stack that was meant to be pushed consisted of two diffs. The first one changes the behavior and the second one the change in tests.
If only one is pushed, then we either get unexpected failures or unexpected passes. This is what happens here.

Why only one was pushed, is completely unclear to me though :/
Looking.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/705c898dae6b
make sanitize/sanitizeToString param's non-optional r=ckerschb,emilio
https://hg.mozilla.org/integration/autoland/rev/f4f1cc7c4456
update WPT for optional sanitize arguments r=ckerschb

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27757 for changes under testing/web-platform/tests

Comment 18

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/705c898dae6b
https://hg.mozilla.org/mozilla-central/rev/f4f1cc7c4456

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 20

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot