[sanitizer] interop with current, simple tests in wpt
Categories
(Core :: DOM: Security, enhancement, P2)
Tracking
()
People
(Reporter: freddy, Assigned: freddy)
References
(Blocks 1 open bug)
Details
(Whiteboard: [domsecurity-active], [wptsync upstream])
Attachments
(5 files)
There are some various wpt test failures, that we need to fix before we can enable the tests to be run in our CI.
This is the behavior we need:
sanitizeToString("") -> returns empty string
sanitizeToString() -> throws, missing argument
sanitizeToString(undefined) -> parses through the Fragment Parsing algorithm as "undefined"
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a679f29cc976 map sanitizer-api folder in wpt to DOM: Security r=jgraham DONTBUILD
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•3 years ago
|
||
This is missing a couple of patches, oddly.
|
|
Assignee | |
Comment 5•3 years ago
|
||
|
|
Assignee | |
Comment 6•3 years ago
|
||
Depends on D105741
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ca33c618714 Rename Sanitizer API tests to require SecureContext r=jgraham https://hg.mozilla.org/integration/autoland/rev/47a8f522b91b Adjust Sanitizer API test expectations for SecureContext r=jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27698 for changes under testing/web-platform/tests
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
|
|
Assignee | |
Comment 11•3 years ago
|
||
|
|
Assignee | |
Comment 12•3 years ago
|
||
Depends on D105953
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 13•3 years ago
|
||
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cffeff2a2803 make sanitize/sanitizeToString param's non-optional r=ckerschb,emilio
|
||
Comment 14•3 years ago
|
||
Backed out for wpt sanitizer-api related failures.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=330911082&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/b422dd886e036907f35269f381f43785873c5296
|
|
Assignee | |
Comment 15•3 years ago
|
||
The stack that was meant to be pushed consisted of two diffs. The first one changes the behavior and the second one the change in tests.
If only one is pushed, then we either get unexpected failures or unexpected passes. This is what happens here.
Why only one was pushed, is completely unclear to me though :/
Looking.
|
|
||
Comment 16•3 years ago
|
||
Pushed by fbraun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/705c898dae6b make sanitize/sanitizeToString param's non-optional r=ckerschb,emilio https://hg.mozilla.org/integration/autoland/rev/f4f1cc7c4456 update WPT for optional sanitize arguments r=ckerschb
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27757 for changes under testing/web-platform/tests
|
||
Comment 18•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/705c898dae6b
https://hg.mozilla.org/mozilla-central/rev/f4f1cc7c4456
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot
Description
•