Closed Bug 1664531 Opened 4 years ago Closed 4 years ago

The UI used to create conditional breakpoints and logpoints should have placeholder text

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: kyleknaggs, Assigned: kyleknaggs)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36

Steps to reproduce:

  1. Visit http://todomvc.com/examples/jquery/#/all and open the Debugger in the Mozilla Developer Tools.
  2. Open app.js in the Editor.
  3. Right-click on the line numbers at the very left side of the Editor and select "Add condition" or "Add log" from the context menu that appears.

Actual results:

The input that appears on the screen does not have any placeholder text.

Expected results:

The input that appears on the screen should have placeholder text.

In addition to what is stated above I would like to add that I think that this is confusing as:

  • The Debugger typically relies on placeholder text and not labels to communicate the purpose of text inputs to a user.
  • Users expect this feature as it is present when using conditional breakpoints and logpoints in both Google Chrome and VSCode.

I also think that it is worth noting that the Debugger used to have this feature before it disappeared approximately 12 - 18 months ago. I do not have confirmation of exactly why this happened. However, my current suspicion is that it was unintentional. My reason for thinking this is that the code that was previously responsible for rendering placeholder text to these inputs is still present in ConditionalPanel.js.

Type: enhancement → defect

Before this patch the CodeMirror instance used to create Conditional Breakpoints and Logpoints did not have placeholder text.

This patch adds placeholder text to this CodeMirror instance by:

  1. Adding the CodeMirror addon responsible for creating placeholder text.
  2. Updating webpack.config.js.
  3. Regenerating codemirror.bundle.js.
  4. Matching the color of the placholder text in these CodeMirror instances to the color of placeholder text in the rest of the Debugger.
Assignee: nobody → kyleknaggs
Severity: -- → S3
Status: UNCONFIRMED → NEW
Type: defect → enhancement
Has STR: --- → yes
Ever confirmed: true
Priority: -- → P3
Type: enhancement → defect
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2cae7f0e3ff
Adds placeholder text to the CodeMirror instances used to create conditional breakpoints and logpoints r=bomsy
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: