1664546 - [wpt-sync] Sync PR 25496 - [weakref] FinalizationRegistry.prototype.cleanupSome & "maybe" GC interleaved with queueMicrotask, MutationObserver

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25496 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25496
Details from upstream follow.

b'Rick Waldron <[e-mail]>' wrote:

[weakref] FinalizationRegistry.prototype.cleanupSome & "maybe" GC interleaved with queueMicrotask, MutationObserver

@jugglinmike these are variants of https://github.com/web-platform-tests/wpt/blob/master/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback.optional.any.js, where the generic await ticks++; has been replaced with:

• queueMicrotask
• queueMicrotaskByMutationObserver (which is a wrapper around a mutation observer)

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=47ce3541fee67e0a74dbdf1c89c3cbfdec6ce9a8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 1 subtests

Status Summary

Firefox

OK : 5
FAIL : 5

Chrome

OK : 5
FAIL : 5

Safari

ERROR: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback-queueMicrotask.optional.any.worker.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL)
/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback-queueMicrotask.optional.any.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL)
/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback-queueMicrotaskMutationObserver.optional.window.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL)
/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback.optional.any.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL)
/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback.optional.any.worker.html
cleanupCallback has only one optional chance to be called for a GC that cleans up a registered target.: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5026f7167f1
[wpt PR 25496] - [weakref] FinalizationRegistry.prototype.cleanupSome & "maybe" GC interleaved with queueMicrotask, MutationObserver, a=testonly
https://hg.mozilla.org/integration/autoland/rev/236b0e8f92c4
[wpt PR 25496] - Update wpt metadata, a=testonly

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e5026f7167f1
https://hg.mozilla.org/mozilla-central/rev/236b0e8f92c4