1664575 - Crash in [@ mozilla::dom::Navigator::HasCreatedMediaSession]

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[u608768]

Crash report: https://crash-stats.mozilla.org/report/index/f021d018-1201-4143-84ff-b82f40200910

Top 10 frames of crashing thread:

0 XUL mozilla::dom::Navigator::HasCreatedMediaSession const dom/base/Navigator.cpp:2108
1 XUL mozilla::dom::ContentPlaybackController::GetMediaSession const dom/media/mediacontrol/ContentPlaybackController.cpp:34
2 XUL mozilla::dom::ContentPlaybackController::IsMediaSessionActionSupported const dom/media/mediacontrol/ContentPlaybackController.cpp:73
3 XUL mozilla::dom::ContentPlaybackController::Pause dom/media/mediacontrol/ContentPlaybackController.cpp:110
4 XUL mozilla::dom::ContentMediaControlKeyHandler::HandleMediaControlAction dom/media/mediacontrol/ContentPlaybackController.cpp:174
5 XUL mozilla::dom::ContentChild::RecvUpdateMediaControlAction dom/ipc/ContentChild.cpp:3551
6 XUL mozilla::dom::PContentChild::OnMessageReceived ipc/ipdl/PContentChild.cpp:13169
7 XUL mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2074
8 XUL mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1953
9 XUL mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:512

Looks like we don't have a inner window, so window->GetNavigator() returns nullptr, and then we try to deref that.

Multiple crashes for a single OS X installation, and one crash on Android.

Comment 1

[u608768]

Attachment: Bug 1664575 - Null check navigator in ContentPlaybackController::GetMediaSession, r?chunmin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab80644987a0
Null check navigator in ContentPlaybackController::GetMediaSession, r=chunmin

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ab80644987a0