1664643 - timer.jsm could be removed

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, task)

Description

[Mark Banner (:standard8)]

timer.jsm (EnigmailTimer) appears to be a wrapper around Timer.jsm.

I'm not sure why it wraps the setTimeout callback with an additional clearTimeout, as that isn't necessary.

Hence, I think all of these instances could be replaced:

https://searchfox.org/comm-central/search?q=EnigmailTimer&path=&case=false&regexp=false

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1664643 - Replace imports in some openpgp jsm files with lazy getters. r?kaie!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1664643 - Remove EnigmailTimer as it is just a wrapper around Timer.jsm. r?kaie!

Depends on D90024

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1664643 - Remove obsolete EnigmailEvents. r?kaie!

Depends on D90025

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f7adc5d5c5b2
Replace imports in some openpgp jsm files with lazy getters. r=kaie
https://hg.mozilla.org/comm-central/rev/893bc9ef47a8
Remove EnigmailTimer as it is just a wrapper around Timer.jsm. r=kaie
https://hg.mozilla.org/comm-central/rev/ce507044e540
Remove obsolete EnigmailEvents. r=kaie