1664655 - Make nsDocShell::SynchronizeLayoutHistoryState update loading entry

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Peter Van der Beken [:peterv]]

With session history in the parent we don't have real shared data for session history entries in the child process. When we load a new page we synchronize the layout history data on the currently active entry when unloading the page. If the newly loading page shares data with the previous page, then at that point the loading entry has already been created in the child process, but it's missing the synchronized layout history data.
Maybe we should consider real shared data in the child process. For now, updating the loading entry when needed seems to work well enough to fix a bunch of tests.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1664655 - Update loading entry's layout history state if it shares it with the current active entry. r=smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac1e652efeb6
Update loading entry's layout history state if it shares it with the current active entry. r=smaug

Comment 3

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1664656, bug 1664655) for multiple failures in checkouts/gecko/docshell/base/nsDocShell.cpp

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316168391&repo=autoland&lineNumber=5302

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=c8c1abf5f616a2a06013b8ffea7f38ee8dee6e7b

Backout:
https://hg.mozilla.org/integration/autoland/rev/fb74feccb375f80556abeac33bae752b222a81ee

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e810830b97de
Update loading entry's layout history state if it shares it with the current active entry. r=smaug

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e810830b97de