Closed Bug 1664661 Opened 4 years ago Closed 4 years ago

New desktop zooming scrollbars at wrong position when pinch zoomed overflow hidden and layout scroll offset isn't 0

Categories

(Core :: Layout: Scrolling and Overflow, defect)

Product:
Core
Component:
Layout: Scrolling and Overflow
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(2 files)

bugm4a.html
2.65 KB, text/html
Details
Bug 1664661. Make ScrollFrameHelper::UpdateScrollbarPosition use the same calculation for scrollbar attributes as ScrollFrameHelper::ReflowFinished. r?kats
47 bytes, text/x-phabricator-request
Details | Review
Attached file bugm4a.html —

Open the attached testcase. Scroll down. Click 'toggle'. Pinch zoom in. Scroll around. Scrollbars are not correctly positioned.

UpdateScrollbarPosition should have been using scroll range and not scrolled rect for a long time. It didn't matter because we only used the top left of the rect which matched until bug 1654933 made GetScrollRangeForUserInputEvents return a rect that wasn't located at 0,0.

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7849377294cb
Make ScrollFrameHelper::UpdateScrollbarPosition use the same calculation for scrollbar attributes as ScrollFrameHelper::ReflowFinished. r=kats

https://hg.mozilla.org/mozilla-central/rev/7849377294cb

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: