1664661 - New desktop zooming scrollbars at wrong position when pinch zoomed overflow hidden and layout scroll offset isn't 0

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: bugm4a.html

Open the attached testcase. Scroll down. Click 'toggle'. Pinch zoom in. Scroll around. Scrollbars are not correctly positioned.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1664661. Make ScrollFrameHelper::UpdateScrollbarPosition use the same calculation for scrollbar attributes as ScrollFrameHelper::ReflowFinished. r?kats

UpdateScrollbarPosition should have been using scroll range and not scrolled rect for a long time. It didn't matter because we only used the top left of the rect which matched until bug 1654933 made GetScrollRangeForUserInputEvents return a rect that wasn't located at 0,0.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7849377294cb
Make ScrollFrameHelper::UpdateScrollbarPosition use the same calculation for scrollbar attributes as ScrollFrameHelper::ReflowFinished. r=kats

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7849377294cb