1664700 - Delay loading parts of Enigmail until delayedStartup

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, task)

Description

[Mark Banner (:standard8)]

BondOpenPGP.jsm currently shows up on performance graphs as taking ~1.9s to load. That's isn't quite true, as it is running init() whilst the module is being loaded, and then spinning the event loop lots - the ChromeUtils.import is seeing the init() as still running, and is counting that.

In any case, the fact we're running init() whilst the module is being loaded may lead to unpredictability as to when it actually gets loaded - especially as we move to lazy loading modules.

Therefore I think it would be better for BondOpenPGP to be initialised later - I'm proposing in delayedStartup. This is triggered after the initial window has been painted but before the user gets to start doing things. I suspect we might be able to delay it further, but I don't really know how important this is to be initialised earlier. Thoughts welcome.

In this bug, I also want to move init routines for EnigmailVerify and EnigmailKeyRing - they both appear to be likely to be used in a session, so having an explicit point is probably good as well.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1664700 - Delay some Enigmail modules until delayedStartup to avoid front-loading the startup process. r?kaie!

Depends on D90041

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f97d0a2f0cc6
Delay some Enigmail modules until delayedStartup to avoid front-loading the startup process. r=kaie