1664718 - Allow :is() and :where() to have better error recovery.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

See https://github.com/w3c/csswg-drafts/issues/3264

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1664718 - Minor cleanup: Use shorthand initialization in selectors. r=#style

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1664718 - Allow :is() and :where() to have better error recovery. r=xidorn

Adjust is-where-parsing.html to work with both the new and old behavior,
and add a test for the new behavior.

Depends on D90049

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da187b003f27
Minor cleanup: Use shorthand initialization in selectors. r=xidorn

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/da187b003f27

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8a8791a26ed
Allow :is() and :where() to have better error recovery. r=xidorn

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25519 for changes under testing/web-platform/tests

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62e71d3b6b32
Fix selectors unit tests.

Comment 8

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1664718) for causing wpt and bc failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/4bb4dfe9dc2d82a6a651bc830bcbdd26cdae5b65

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=wpt&tochange=50146706fd41505d10d9685827b0dbe93f0bc18d&fromchange=0f7dc1b122c624c2cc3e2a095cbcda00fd1900b9

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Csuccess%2Crunnable&searchStr=bc&tochange=50146706fd41505d10d9685827b0dbe93f0bc18d&fromchange=d9084ec8e2b36212dffcdbd979ea728189d71b2c

Failure log:

• wpt: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315653115&repo=autoland&lineNumber=2175
• bc: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315653601&repo=autoland&lineNumber=3225

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/078dc5a03661
Allow :is() and :where() to have better error recovery. r=xidorn

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/078dc5a03661

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/850df777262d
Port bug 1664718 - Copy changes to comm-central version of browser_parsable_css.js. rs=bustage-fix

Comment 13

[Rachel Andrew]

Updated the :where() and :is() pages:

• https://wiki.developer.mozilla.org/en-US/docs/Web/CSS/:where
• https://wiki.developer.mozilla.org/en-US/docs/Web/CSS/:is

Updated BDC, and also added a note in the 82 release notes.