1664725 - Getting expecting rejection to match gets <unknown> instead of actual expectation.

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P5)

Description

[Michelle Goossens [:masterwayz]]

This seems to be caused by this commit: https://hg.mozilla.org/mozilla-central/rev/9ae69a2f818d
When removing .toSource() on here: https://searchfox.org/mozilla-central/source/toolkit/components/extensions/child/ext-test.js#89 then it works normally again.

It makes debugging harder as instead of reporting what is expected to match, for example:
Promise rejected, expecting rejection to match 'matching string here', we get:
Promise rejected, expecting rejection to match <unknown>.

Comment 1

[Rob Wu [:robwu]]

A way to trigger this bug is as follows:

browser.test.assertRejects(
  Promise.reject("dummy"),
  /not-dummy/,
  "intentional failure"
);

.toSource is not available any more because of bug 1565170.
That code path can be reached through https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/toolkit/components/extensions/child/ext-test.js#209-211,231-233
depending on the value of expectedError.

Potential values for expectedError are specified by the JSON schema at https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/toolkit/components/extensions/schemas/test.json#145-149,165-169,180-185

toSource was removed in bug 1565170, and its purpose was to create a human-readable serialization of a value. In these cases, String(value) should probably have the desired result.

Do you want to submit a patch?

Comment 2

[Michelle Goossens [:masterwayz]]

Sure, I'll take it.

Comment 3

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1664725 - Fix expecting rejection to match unknown to actual expectation r=robwu

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e97b14b6493
Fix expecting rejection to match unknown to actual expectation r=robwu

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4e97b14b6493