1664732 - Convert DOMEventMarkerPayload to new marker API

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

There is only one call site, so this is an easy one to do, and I worked on it as part of the initial bug 1646266 WIP so it's ready to go.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1664732 - Transition DOMEvent to markers 2.0 - r?gregtatum

There is only one call site, so I believe it's best to have the marker type there.
I think it's cleaner this way, this marker type doesn't need to be present in a header shared by all users of the profiler.

The only downside is that we cannot unit-test this particular marker type automatically anymore, but I don't think it's strictly needed:

• There are still plenty of tests checking that generic marker types work end-to-end, so we can have some confidence this specific one can do its job.
• If it somehow started to fail, either it would be quickly found that it breaks the front-end, or it wouldn't have any visible effect in which case it's not a big issue.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb9ca4e848a0
Transition DOMEvent to markers 2.0 - r=gregtatum,smaug

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bb9ca4e848a0