1664760 - Order of results in search mode is wrong if "Show search suggestions before history" is unchecked

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Marco Bonardo [:mak]]

When restricting to search (with ?) we used to put suggestions first, history after, basically we use matchBucketsSearch instead of matchBuckets.
This is done here: https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarMuxerUnifiedComplete.jsm#129
Apparently the heuristic doesn't have anymore RESULT_TYPE.SEARCH in search mode, and that breaks the ordering.

I'm probably going to change the RESULT_TYPE in bug 1663686, that may also fix this bug.

Comment 1

[Marco Bonardo [:mak]]

Ok, I was misremebering, we stopped setting matchBucketsSearch, and that means there's no special sorting depending on the heuristic result... Though it still seems to make sense to put history later in search mode with an engine.

In reality we are now discussing again whether browsing history should be shown or not. So I guess I won't fix this in bug 1663686 for now.

Comment 2

[Marco Bonardo [:mak]]

from a long discussion in #search, while here I should look at why restyleSearches is removing all the non-restyled results, make the redirects filter in UnifiedComplete depending on that pref (filter targets if we restyle).

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1664760 - Improve the set of results when in search mode for a non-general search engine. r=adw

• always keep search suggestions for
  • use restyleSearches only in search mode to get cleaner history results and dedupe against search history
  • filter redirects differently depending on restyleSearches

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35a5c311e239
Improve the set of results when in search mode for a non-general search engine. r=adw

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/35a5c311e239