1664767 - Remove defer usage in devtools\client\fronts\device.js

Status: RESOLVED FIXED

(DevTools :: Shared Components, task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

We should use new Promise instead.

Honza

Comment 1

[Fabien Casters [:vaga]]

Hi,
I changed defer to new Promise(...) but the method screenshotToBlob seems to be unused.

$ rg screenshotToBlob ./mozilla-unified/
./devtools/client/fronts/device.js
37:  screenshotToBlob() {

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Fabien, sorry for the delay!

I think we should remove the method entirely as part of fixing this bug.

Julian, can you please confirm?

Honza

Comment 3

[Julian Descottes [:jdescottes]]

Good call, that seems unused. Let's remove this method!

Looks like getDescription can also be removed since it was only needed for backward compat. Will file another bug.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks Julian!

Fabien, are you still interested, should I assign this to you?

Comment 5

[Fabien Casters [:vaga]]

Yes, you can assign me!

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Awesome, done!

Comment 7

[Fabien Casters [:vaga]]

Attachment: Bug 1664767 - Remove defer usage in devtools\client\fronts\device.js r=honza

Finally, screenshotToBlob method is unused.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5864aed7409
Remove defer usage in devtools\client\fronts\device.js r=Honza

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e5864aed7409