Closed Bug 1664767 Opened 6 months ago Closed 4 months ago

Remove defer usage in devtools\client\fronts\device.js

Categories

(DevTools :: Shared Components, task, P3)

task

Tracking

(firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: Honza, Assigned: vaga)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

We should use new Promise instead.

Honza

Hi,
I changed defer to new Promise(...) but the method screenshotToBlob seems to be unused.

$ rg screenshotToBlob ./mozilla-unified/
./devtools/client/fronts/device.js
37:  screenshotToBlob() {
Flags: needinfo?(odvarko)

Fabien, sorry for the delay!

I think we should remove the method entirely as part of fixing this bug.

Julian, can you please confirm?

Honza

Flags: needinfo?(odvarko) → needinfo?(jdescottes)

Good call, that seems unused. Let's remove this method!

Looks like getDescription can also be removed since it was only needed for backward compat. Will file another bug.

Flags: needinfo?(jdescottes)

Thanks Julian!

Fabien, are you still interested, should I assign this to you?

Flags: needinfo?(fabien)

Yes, you can assign me!

Flags: needinfo?(fabien) → needinfo?(odvarko)

Awesome, done!

Assignee: nobody → fabien
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)

Finally, screenshotToBlob method is unused.

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5864aed7409
Remove defer usage in devtools\client\fronts\device.js r=Honza
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.