1664770 - Use QM_TRY* for storage initialization code

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Tom Tung [:tt, :ttung]]

From our telemetry records for 79 Release users, we have:

• UpgradeStorageFrom0_0To1_0
  • 26,858 failures (5.95%)
  • 424,696 successes (94.05%)
• UpgradeStorageFrom1_0To2_0
  • 5,226 (1.02%)
  • 508,791 (98.98%)
• UpgradeStorageFrom2_0To2_1
  • 7,214 (1.32%)
  • 537,714 (98.68%)
• UpgradeStorageFrom2_1To2_2
  • 52,234 (5.35%)
  • 923,947 (94.65%)
• UpgradeStorageFrom2_2To2_3
  • 2,113 (0.18%)
  • 1,151,438 (99.82%)

The goal here is to add QM_TRY* for the related code so that we might be able to figure out failures.

Note that from TMO, it seems we don't have failures around upgrade code on Nithgly, but there are a few for Beta https://mzl.la/33q4KFT.

Comment 1

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1664770 - Use QM_TRY* for storage initialization code;

Comment 2

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1664770 - Use QM_TRY* for GetBinaryInputStream and GetBinaryOutputStream;

Depends on D90094

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1664770 - Use QM_TRY* for metadata related functions;

Depends on D90118

Comment 4

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1664770 - Use QM_TRY* for upgrade classes' base classes;

Depends on D90119

Comment 5

[Tom Tung [:tt, :ttung]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=38c156bddcd92a2d217a6be0f6000965953613ee

Comment 6

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1664770 - Replace ToResultInvoke with MOZ_TO_RESULT_INVOKE_TYPED;

Comment 7

[Phabricator Automation]

Comment on attachment 9176228 [details]
Bug 1664770 - Replace ToResultInvoke with MOZ_TO_RESULT_INVOKE_TYPED;

Revision D90523 was moved to bug 1665565. Setting attachment 9176228 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/620a47766320
Use QM_TRY* for storage initialization code; r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/5a535579e053
Use QM_TRY* for GetBinaryInputStream and GetBinaryOutputStream; r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/66910ba403a6
Use QM_TRY* for metadata related functions; r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/db810f5d5a60
Use QM_TRY* for upgrade classes' base classes; r=dom-workers-and-storage-reviewers,janv,sg

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/620a47766320
https://hg.mozilla.org/mozilla-central/rev/5a535579e053
https://hg.mozilla.org/mozilla-central/rev/66910ba403a6
https://hg.mozilla.org/mozilla-central/rev/db810f5d5a60