1664849 - Log ad impressions/clicks on organic SERPS

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Ben Miroglio [:bmiroglio]]

We currently collect organic searches in telemetry, which are searches that happen i.e directly on google.com and not through a Firefox access point, and thus do not monetize.

Proposal: Collect ad clicks and impressions for organic SERPs. This will allow us to estimate the functional differences in both the types of searches users make on i.e. google.com versus our SAPs, along with any ad-serving variations on the SERP pages which might depend on the attributed search source (Google organic vs. Firefox SAP).

This dovetails with another bug I just filed: Log the search source for ad clicks and searches with ads.

Comment 1

[Mark Banner (:standard8)]

Attachment: Data Collection Review

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1664849 - Extend ad impression/click telemetry to organic SERPS. r?daleharvey!

Comment 3

[Teon Brooks [:teon]]

Comment on attachment 9188673 [details]
Data Collection Review

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file Scalars.yaml and the Probe Dictionary.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :teon is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaee4ba7af2e
Extend ad impression/click telemetry to organic SERPS. r=daleharvey

Comment 5

[Atila Butkovits]

Backed out for failures on test_urlTelemetry.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/91fbc2fbea07511eb8f230f9d51142d22873e714

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=PyW5ut-VS3KMYi2QGvrYQw.0&revision=aaee4ba7af2ed041fba4b5e2302adb1b8ed779e0&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cxpcshell%2Ctests%2Ctest-linux1804-64-asan%2Fopt-xpcshell-e10s%2Cx3

Failure log: https://treeherder.mozilla.org/logviewer?job_id=322429233&repo=autoland&lineNumber=2888

Comment 6

[Mark Banner (:standard8)]

Oops I missed that test and a minor bug I found in doing so.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/583b3d547e37
Extend ad impression/click telemetry to organic SERPS. r=daleharvey

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/583b3d547e37

Comment 9

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We verified this issue using Fx 85.0b5 on Windows 10 x64, Ubuntu 20.0 LTS and macOS 10.13.