1664938 - Remove reftests flexbox-intrinsic-ratio*html that have been duplicated-with-rewrites to use JS-based testing

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task)

Description

[Daniel Holbert [:dholbert]]

David Grogan is porting some of our w3c-css/submitted/ flexbox reftests to be JS-based with checkLayout and individual subtests, so that individual/partial failures can more easily be annotated.

He's just landed some of this upstream here:
https://github.com/web-platform-tests/wpt/pull/25313

I'm filing this bug on removing the now-"old" versions of these tests from our tree, so that we're not redundantly testing the same thing.

Comment 1

[Daniel Holbert [:dholbert]]

(I'm waiting on our next wpt sync to pull in the new versions of these tests before proceeding here. The first new test file is named image-as-flexitem-size-001.html, and https://searchfox.org/mozilla-central/search?q=image-as-flexitem-size-001.html&path= says that this file doesn't exist yet. It should appear in https://searchfox.org/mozilla-central/source/testing/web-platform/meta/css/css-flexbox when it arrives.)

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1664938 - Remove flexbox-intrinsic-ratio-00*.html on wpt, and their *.ini in our meta.

Per bug 1664938 comment 0, these reftests have been ported by Chromium
team and lived in css/css-flexbox on WPT, and Bug 1490969 removed
w3c-css/submitted/. We can just remove these old reftests on WPT.

This patch is generated via:

$ git rm testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-00*
$ git rm testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-00*

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

-1 to dholbert's needinfo :)

Comment 4

[Daniel Holbert [:dholbert]]

Thanks, TYLin!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ffbf6bef746
Remove flexbox-intrinsic-ratio-00*.html on wpt, and their *.ini in our meta. r=boris

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26270 for changes under testing/web-platform/tests

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2ffbf6bef746

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot