Closed Bug 1664961 Opened 4 years ago Closed 4 years ago

Crash in nsDocShell::Reload() in browser_security-1.js with SessionHistoryInParent

Categories

(Core :: DOM: Navigation, defect, P2)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Project Flags:
Fission Milestone M6b
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(1 file)

Bug 1664961: check if child process when processing docshell Reload() r=peterv
47 bytes, text/x-phabricator-request
Details | Review

If you enable SessionHistoryInParent for fission, bc11 crashes in browser_security-1.js in nsDocShell::Reload(), because ContentChild::GetSingleton() is null (since it's not running in the child).

It needs to check if we're in the parent, like most other uses of GetSingleton().

Component: DOM → Preferences
Product: Remote Protocol → Firefox

This is a fission session-history bug; moving to DOM:Navigation

Component: Preferences → DOM: Navigation
Product: Firefox → Core
Blocks: fission-history-m6b
Severity: -- → S2
Status: NEW → ASSIGNED
Priority: -- → P2
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/autoland/rev/1088f83fc64f
check if child process when processing docshell Reload() r=smaug

https://hg.mozilla.org/mozilla-central/rev/1088f83fc64f

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: