1664995 - Implement and add tests for OCSP network partitioning

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Description

[Arthur Edelstein [:arthur]]

The unit tests for FPI may be of use here.

Comment 1

[Tim Huang[:timhuang]]

See here, OCSP is only isolated by the firstPartyDomain. It should also be isolated by the partitionKey.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1664995 - Part 1: Make OCSP cache to be aware of the partitionKey in the originAttributes. r?keeler

The patch add partitionKey into the certIDHash to isolate OCSP by the
partitionKey.

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1664995 - Part 2: Add tests to verify that OCSP cache is isolated by partitionKey. r?keeler

Depends on D123957

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1664995 - Part 3: Add tests for private browsing mode. r?keeler

Depends on D123958

Comment 5

[Tim Huang[:timhuang]]

Attachment: Bug 1664995 - Part 4: Enable OCSP partiitoning in strict mode. r?johannh

Depends on D124470

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1664995 - Part 5: Add tests for OCSP partitioning flag of strict mode. r?johannh

Depends on D124471

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c155497d52d
Part 1: Make OCSP cache to be aware of the partitionKey in the originAttributes. r=keeler
https://hg.mozilla.org/integration/autoland/rev/28fc69e4c7c6
Part 2: Add tests to verify that OCSP cache is isolated by partitionKey. r=keeler
https://hg.mozilla.org/integration/autoland/rev/db20506f2cb1
Part 3: Add tests for private browsing mode. r=keeler
https://hg.mozilla.org/integration/autoland/rev/afab854c5e44
Part 4: Enable OCSP partiitoning in strict mode. r=johannh
https://hg.mozilla.org/integration/autoland/rev/50950e6a57dc
Part 5: Add tests for OCSP partitioning flag of strict mode. r=johannh

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5c155497d52d
https://hg.mozilla.org/mozilla-central/rev/28fc69e4c7c6
https://hg.mozilla.org/mozilla-central/rev/db20506f2cb1
https://hg.mozilla.org/mozilla-central/rev/afab854c5e44
https://hg.mozilla.org/mozilla-central/rev/50950e6a57dc