Closed Bug 1665007 Opened 4 years ago Closed 4 years ago

Allow more room for DeviceCapabilities arrays for safety.

Categories

(Core :: Printing: Setup, defect, P1)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- disabled
firefox81 --- disabled
firefox82 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

(Whiteboard: [print2020_v82][old-ui-])

Attachments

(1 file)

There are also a couple other places we allocate space for a DEVMODE record, so we should probably pad all of them. (In nsDeviceContextSpecWin.cpp and nsPrintDialogUtil.cpp, IIRC.)

This also doubles the memory we allocate for DEVMODEs, when that value has been
returned from the other uses of DocumentProperties, because apparently some
drivers do not return the correct size.

Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/26bad00de34a
Double the memory we allow for DeviceCapabilities arrays for safety. r=jfkthame
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Blocks: 1665706
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: