166502 - Mail search does a complete boolean evaluation

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect)

Description

[Rene Pronk]

Build 2002083108 on win2000

Mail search seems to do a complete boolean evaluation on the search criteria:
If I search for a subject containing 'qqqq' it won't find anything and
needs approx. 0.5 seconds for this.
If I search for a subject containing 'qqqq' *and* the body containing
'blablabla' it finds again nothing but now needs approx 17.5 seconds for
this.
It should of course do this last search also in 0.5 seconds since after
checking the subject it wouldn't need to check the body anymore.
The order in which I specify the criteria doesn't matter.
Ideally Mozilla should reorder the criteria such that the fastest/easiest
criteria would be matched first and the slow ones last.

Comment 1

[Stefan Magdalinski]

I've always assumed that if you're doing a 'match all criteria', it uses lazy 
evaluation on the criteria. fixing this would make the freezing/ 100% cpu usage 
issues of critical bug

http://bugzilla.mozilla.org/show_bug.cgi?id=127398

much less severe in practical terms. I often used a subject=/sender= filter in 
conjunction with body= in order to make it faster, but I now realise this is 
pointless.

The re-ordering is actually pretty simple; all apart from body= use the summary 
file (correct?), and are quick,  so it just has to put any body= searches last. 

This would be a huge perf win in many search cases.

Comment 2

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 3

[Alfonso Martinez]

*** Bug 245593 has been marked as a duplicate of this bug. ***

Comment 4

[Scott MacGregor]

not a 1.0 stopper

Comment 5

[Howard Chu]

This bug is fixed by the patch in bug #295088

Comment 6

[Aaron Lawrence]

*** Bug 154867 has been marked as a duplicate of this bug. ***

Comment 7

[Wayne Mery (:wsmwk)]

*** Bug 232455 has been marked as a duplicate of this bug. ***

Comment 8

[mozilla3eran]

Regarding comment 5:
Assuming the patch in bug #295088 has been applied to Thunderbird 1.5, it did not fix this bug. Any search including a Body condition is still extremely slow, even if ANDed with a cheap condition that's never fulfilled.

Comment 9

[David :Bienvenu]

this is fixed on the trunk and the 2.0 branch. The fix is not in 1.5