1665096 - Web-Platform-Tests: resource-timing resource_nested_dedicated_worker.worker.html failure

Status: UNCONFIRMED

(Core :: Performance, defect)

Description

[Nic Jansma]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36

Steps to reproduce:

From a triage[1] of currently failing WPT resource-timing tests[2], the following Firefox test failures may (or may not be) be related to Service Workers:

https://wpt.fyi/results/resource-timing/resource_nested_dedicated_worker.worker.html?label=master&label=experimental&aligned

[1] https://github.com/w3c/resource-timing/issues/233
[2] https://wpt.fyi/results/resource-timing?label=master&label=experimental&aligned

Actual results:

Test failure

Expected results:

Test pass

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Andrew Creskey [:acreskey]]

I will see if I can get to the root of this.

Comment 3

[Andrew Creskey [:acreskey]]

I can confirm that we are not adding resource timing entries for the nested Service Worker.

Comment 4

[Andrew Creskey [:acreskey]]

Attachment: Bug 1665096 Web-Platform-Tests: resource-timing resource_nested_dedicated_worker.worker.html failure r=?

Nested workers were not associated with their parent's performance timelines.

Fixed by passing the parent worker (if present) via workerinternals::ChannelFromScriptURLMainThread() to, ultimately, dom::ChannelFromScriptURL().

Also fixed an issue in workerinternals::ChannelFromScriptURLMainThread() where worker scripts were misidentified as main scripts.

Comment 5

[Andrew Creskey [:acreskey]]

:baku, I see that you did the heavy lifting to implement resource timing in web workers (Bug 1425458)

I put up a patch that fixes this edge case, with the caveat that I haven't seen any of the code before.

Can I ask you to have a look and tell me if this is reasonable?

And I image that there are tests that I would need to add as well?