1665156 - Different input style for username and password in http authentication dialog

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Asif Youssuff]

Attachment: image.png

STR:

1. Go to https://jigsaw.w3.org/HTTP/Basic/
2. tab through the text inputs for username and password

What happens:

The styling (size, focus) is inconsistent

Expected result:

Consistent styling.

Comment 1

[Tom S [:evilpie]]

Adding an explicit type="text" to the input will fix this, because the custom CSS doesn't match without a type attribute.

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1665156 - commonDialog.xhtml: Explicitly set input type 'text' to fix broken style in SubDialog. r=gijs

Comment 3

[Paul Zühlcke [:pbz]]

(In reply to Tom Schuster [:evilpie] from comment #1)

Adding an explicit type="text" to the input will fix this, because the custom CSS doesn't match without a type attribute.

Thanks! That was the issue. I've created a patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abe4ad9d488d
commonDialog.xhtml: Explicitly set input type 'text' to fix broken style in SubDialog. r=Gijs

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 613785

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/abe4ad9d488d

Comment 7

[Cristian Fogel [:cfogel]]

Verified with 82.0b7 on macOS 11.0, Windows 10; styling appears consistent on each OS now.