1665167 - [meta] Bug 685445 has regressed (Contenteditable=false elements in contenteditable=true elements cannot be deleted by using Backspace/Delete)

Status: RESOLVED DUPLICATE of bug 1873155

(Core :: DOM: Editor, task)

Description

[Emilio Cobos Álvarez [:emilio]]

+++ This bug was initially created as a clone of Bug #685445 +++

I can reproduce the issue using the test-case in the bug.

Makoto, it seems you fixed bug 1394758, is there any chance you could take a look?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

(see above)

Comment 2

[ehonkulus]

additional test case/simple codepen, https://codepen.io/burritoiand/pen/xxVJdaL, try deleting the text in FireFox, thanks!

Comment 3

[Rares Doghi, Desktop QA]

Hi, I tried to get a regression range for this issue by using the steps from Comment 2 but it seems to be happening all the way down to Fx 43. I will remove the regression window flag.

Comment 4

[Makoto Kato [:m_kato]]

I look this.

Comment 6

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cefa67af4c936ac32345a2916db24b0965a2df5d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1fd035091589c04dca1380924e9523ac2ef06b1a

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1665167 - Part 1. DeleteNodeWithTransaction should allow non-editable node when parent is editable.

Even if non-editable node, DeleteNodeWithTransaction should be able to
remove it if parent is editable.

Example, <div contenteditable><img contenteditable=false /></div> should
allow to remove <img> element by backspace key.

Comment 8

[Makoto Kato [:m_kato]]

Attachment: Bug 1665167 - Part 2. Move some utilities methods to EditorUtils.

Depends on D92582

Comment 9

[Makoto Kato [:m_kato]]

Attachment: Bug 1665167 - Part 3. WSRunObject shouldn't set non-editable leaf node to reason content.

Actually, we handle non-editable node as special node like <img>.

WSRunObject scans text node for white space handling, and reason content is
sometimes leaf node (text node). But since we use reason content for
HandleDeleteAtomicContent, we cannot remove it due to non-editable and we
don't know whether this leaf (and this non-editable tree) are removable.

So we would like to change reason content from leaf node of non-editable to
topmost non-editable node if possible.

Also, using [Delete] key still use frame selection, so WSRunObject don't still
consider this situation yet. And actually we don't support deep complex
case (see test case) yet since Chrome doesn't remove any elements on this
test case.

Depends on D92586

Comment 10

[Makoto Kato [:m_kato]]

Attachment: Bug 1665167 - Part 4. Update browserscope tests for nested contenteditable.

https://searchfox.org/mozilla-central/rev/35245411b9e8a911fe3f5adb0632c3394f8b4ccb/editor/libeditor/tests/browserscope/lib/richtext2/richtext2/tests/delete.py#264-267 etc are incorrect for current behaviour.

browserscope isn't active project, so there is no way to feedback this.

Depends on D92587

Comment 12

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3dc9058ecca3557ad41b37c44c38abefbc34b63c

Comment 13

[Makoto Kato [:m_kato]]

selection issue is moving to bug 1670531 since editor uses nsFrameSelection for backspace/delete.

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The remaing bugs should be handled in bug 1873155.