Closed Bug 1665194 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25551 - Revert "[mathml] Use post.underlineThickness for the default fraction rulethickness"

Categories

(Core :: MathML, task, P4)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25551 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25551
Details from upstream follow.

b'David Bienvenu <davidbienvenu@google.com>' wrote:

Revert "[mathml] Use post.underlineThickness for the default fraction rulethickness"

This reverts commit d01e107517ff5b1da0544be36c5caaf30c27456e.

Reason for revert: \<breaks win7 bots - https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29>

Original change's description:

[mathml] Use post.underlineThickness for the default fraction rulethickness

MathML Core currently defines fallback values to use when no MATH table
is available. This CL performs the remaining work to ensure fractions
align with the specification. It also adds WPT test to check these
fraction fallback parameters, although testing them extensively is
difficult.

Bug: 6606, 1058369
Change-Id: Ic916c0c4b925674d526d78989988e57d8735bf4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410384
Commit-Queue: Frédéric Wang \<fwang@igalia.com>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807083}

TBR=ikilpatrick@chromium.org,fwang@igalia.com,rbuis@igalia.com

Change-Id: Ia8857539d69bbbafda2be5501ac1b766488be77d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 6606
Bug: 1058369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412750
Reviewed-by: David Bienvenu \<davidbienvenu@google.com>
Commit-Queue: David Bienvenu \<davidbienvenu@google.com>
Cr-Commit-Position: refs/heads/master@{#807144}

PR 25551 applied with additional changes from upstream: b88a123fa419ebdf73322f57516d07961aec8e5d
Component: web-platform-tests → MathML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 5 subtests

Status Summary

Firefox

OK : 2
PASS: 9
FAIL: 1

Chrome

OK : 2
PASS: 10

Safari

OK : 2
PASS: 9
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/mathml/presentation-markup/scripts/underover-1.html
Height of scripted elements: FAIL

New Tests That Don't Pass

/mathml/presentation-markup/scripts/underover-1.html
Height of scripted elements: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1224a6b86b23 [wpt PR 25551] - Revert "[mathml] Use post.underlineThickness for the default fraction rulethickness", a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.