1665284 - GV Nightly busted: GleanGeckoMetricsMapping.kt: Duplicate label in when

Status: RESOLVED FIXED

(Core :: Performance: General, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

See the original issue here.

The GV nightly build task seems to have failed from a generated class in Glean:

> Task :browser-engine-gecko-nightly:compileDebugKotlin FAILED
e: warnings found and -Werror specified
w: /build/android-components/components/browser/engine-gecko-nightly/build/generated/source/glean/debug/kotlin/GleanGeckoMetricsMapping.kt: (95, 13): Duplicate label in when

> Task :service-glean:generateReleaseRFile

Task: https://firefox-ci-tc.services.mozilla.com/tasks/groups/DDM8oIucQRyivl5-c5GUgQ
Logs: https://firefoxci.taskcluster-artifacts.net/DDM8oIucQRyivl5-c5GUgQ/0/public/logs/live_backing.log

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

This is blocking our automated GV Nightly version update in AC. Which means the latest GV Nightly won't get into Fenix Nightly. And then a bunch of people will start to complain. :)

Comment 3

[Michael Droettboom [:mdroettboom]]

The issue is that a duplicate telemetry id was introduced in the GV metrics.yaml file here:

https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/geckoview/streaming/metrics.yaml#1082

I think this needs TIME_TO_LOAD_EVENT_END_NO_PRELOAD_MS -> TIME_TO_LOAD_EVENT_START_NO_PRELOAD_MS.

Comment 4

[Chris H-C :chutten]

The problematic definitions were added in bug 1657188 in the Core::Performance product, so I'll move the bug over there.

Comment 5

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665284 - Correct gecko_datapoint for load_event_start_no_preload r?dexter

Bug 1657188 introduced some new telemetry, but one of the metrics had an
incorrect gecko_datapoint, causing GV builds to fail.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/787605ddd0b1
Correct gecko_datapoint for load_event_start_no_preload r=Dexter

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/787605ddd0b1