Closed
Bug 1665307
Opened 4 years ago
Closed 4 years ago
Ensure to really lazily load Log.get
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(firefox82 fixed)
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
Details
(Keywords: perf, Whiteboard: [marionette-fission-mvp][simple])
Attachments
(1 file)
As seen in this review on Phabricator the log module is not lazily loaded because we directly access it:
XPCOMUtils.defineLazyGetter(this, "logger", Log.get);
Instead () => Log.get() should be used.
This needs a fix across all the different Marionette JS modules under /testing/marionette.
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1
|
|
Assignee | |
Updated•4 years ago
|
Whiteboard: [marionette-fission-mvp][simple]
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e3fa8d62f2b [marionette] Lazily load Log.get in all JS modules. r=marionette-reviewers,jdescottes
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•