Open Bug 1665330 Opened 5 years ago Updated 7 months ago

New wpt failures in /html/webappapis/dynamic-markup-insertion/document-write/ [module-dynamic-import.html, module-static-import.html]

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

Details

(Keywords: leave-open, Whiteboard: [wpt])

Attachments

(1 file)

Syncing wpt PR 25430 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

/html/webappapis/dynamic-markup-insertion/document-write/module-dynamic-import.html
document.write in an imported module: FAIL
/html/webappapis/dynamic-markup-insertion/document-write/module-static-import.html
document.write in an imported module: FAIL

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1663596 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Assignee: nobody → ystartsev

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ystartsev, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(ystartsev)
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/760123aa1758 If a script is a module, increment the IgnoreDestructiveWrites counter r=hsivonen
Flags: needinfo?(ystartsev)

Backed out changeset 760123aa1758 (bug 1665330) for WPT failures in /html/webappapis/dynamic-markup-insertion/document-write/module-tla-import.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=326595296&repo=autoland&lineNumber=12935

Backout:
https://hg.mozilla.org/integration/autoland/rev/77dc70a7ac251056a60abbcdb89c8db32a79a253

Flags: needinfo?(ystartsev)
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b4ca02ee3aa If a script is a module, increment the IgnoreDestructiveWrites counter r=hsivonen
Flags: needinfo?(ystartsev)

The leave-open keyword is there and there is no activity for 6 months.
:ystartsev, maybe it's time to close this bug?

Flags: needinfo?(ystartsev)

For anyone curious: The above fix was only for the static imports -- dynamic imports are tricky. I haven't gotten to those yet as I am reworking the module system rn.

Flags: needinfo?(ystartsev)

The leave-open keyword is there and there is no activity for 6 months.
:ystartsev, maybe it's time to close this bug?

Flags: needinfo?(ystartsev)

The bug isn't fixed yet. it should stay open.

Flags: needinfo?(ystartsev)
Assignee: ystartsev → nobody

if i have time i will pick it up later, but document write / dynamic imports still need to be done.

The leave-open keyword is there and there is no activity for 6 months.
:sefeng, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Flags: needinfo?(sefeng)

Leave this open as this bug hasn't fixed yet.

Flags: needinfo?(sefeng)
Severity: -- → S4
Flags: needinfo?(continuation)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: