1665332 - ScrollFrameHelper::mZoomableByAPZ gets cleared when the scroll frame is reconstructed

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1665332. Have ZoomConstraintsClient keep it's ZoomConstraints around so it can be queried later. r?kats

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1665332. Fetch the value of mZoomableByAPZ in the ScrollFrameHelper constructor so it is always correct. r?kats

Otherwise the only time it gets set is when the ZoomConstraintsClient specifically sets it in response to one of the things that can change it. But if the scroll frame gets reconstructed and one of those things don't happen it will be wrong.

This shows up with desktop zooming scrollbars because we check mZoomableByAPZ (or WantAsyncScroll()) before we use the apz scroll path in ScrollFrameHelper::ScrollBy().

Depends on D90383

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1665332. Add test. r?kats

This test covers bug 1665323, bug 1665326, and bug 1665332. (Each bug fixes one problem that comes up with the same STR that this mochitest reproduces.)

I checked that this fails before my patches and passes after them.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03abdf1d3655
Have ZoomConstraintsClient keep it's ZoomConstraints around so it can be queried later. r=kats

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb1437fa93d0
Fetch the value of mZoomableByAPZ in the ScrollFrameHelper constructor so it is always correct. r=kats

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/03abdf1d3655

Comment 7

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=V_7re8-8RI2CkZ_GJUt1nQ.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=41fa4179cc8c20a0664735e69d48355c717e6d7b&failure_classification_id=2

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316359686&repo=autoland&lineNumber=2119

Backout: https://hg.mozilla.org/integration/autoland/rev/43a60e424e7ebb2cda9c614d145906206ec90e80

Comment 8

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1665332. Make sure to initialize all fields of the ZoomConstraints to the correct values on ZoomConstraintsClient in all cases. r?kats

The default constructor initializes the two bools to true.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/134746c4644d
Make sure to initialize all fields of the ZoomConstraints to the correct values on ZoomConstraintsClient in all cases. r=kats

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2b9bbe90d4f
Fetch the value of mZoomableByAPZ in the ScrollFrameHelper constructor so it is always correct. r=kats

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/134746c4644d
https://hg.mozilla.org/mozilla-central/rev/a2b9bbe90d4f

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a6bfdf38fd9
Add test. r=kats

Comment 13

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=C-j5M-ifTiKMYifA-X9Xkg.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=2a6bfdf38fd9c204ac57d2e87b96d20c8d1b38e1

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316622092&repo=autoland&lineNumber=4408

Backout: https://hg.mozilla.org/integration/autoland/rev/2a126c0cc022c6a9c6c1c2e1e31d6445dbe3c4d1

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3657820482d9
Add test. r=kats

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3657820482d9