1665339 - Canceling http auth prompt via the escape key aborts navigation

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[:Gijs (he/him)]

STR:

1. on Nightly with no active http auth sessions, click https://jigsaw.w3.org/HTTP/Basic/
2. hit [esc] to cancel the dialog (note: keyboard is important - clicking "cancel" works correctly)

ER:
If using app/window modal prompts, the page navigates to a page saying "Unauthorized access"

AR:
if using tabmodal prompts, the page stops navigating and you're still looking at this bugzilla report. :-)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 613785

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1665339 - Prevent ESC key on SubDialog from cancelling page load. r=gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f4a2998379b
Prevent ESC key on SubDialog from cancelling page load. r=Gijs

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7f4a2998379b

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pbz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Emma Zühlcke [:emz]]

The tab auth prompts are only enabled in Nightly for now. Uplift is not needed.