1665343 - Not printing revoked blob image

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P2)

Description

[hlavacek.radek]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36 OPR/70.0.3728.178

Steps to reproduce:

Appears in version 80+. The versions before 80 works fine.
Steps:

1. Create canvas and call HTMLCanvasElement.toBlob() method.
2. On callback of created blob, create "img" element and as source add the "URL.createObjectURL(blob)".
3. Add the "img" element into page that you want to print
4. Print page

Actual results:

The image is not printed

Expected results:

The image should be printed

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case

This seems to work, is there any chance you could attach a test-case that reproduces the bug?

Comment 3

[hlavacek.radek]

Attachment: Working test case

Not sure if it is firefox bug anymore, but it wokred in version 79 and older and it works in all other browsers. The problem is with line "URL.revokeObjectURL(url);".

Comment 4

[hlavacek.radek]

But if it is shown on the web page, it should be also printed.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Yeah, that's a bit tricky. This broke in bug 1648064 because that changed the setup to actually allow image requests from the printed page (needed for lazyloaded images).

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Blob image merging test-case.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1665343 - Remove blob specialness in image cache. r=tnikkel

We use it to merge blobs, but that doesn't match the spec. Per:

https://html.spec.whatwg.org/#the-list-of-available-images

We should key off the URI, and thus a revoked image should be able to be
reused if the request is cached. This works to allow printing revoked
blob images, which other browsers allow.

I don't see any way to make that work easily while preserving the blob
image optimization. That being said, it seems other browsers also
re-decode when creating different URLs for the same blob (see the
test-case attached to the bug), so it seems we should be able to live
without it.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1648064

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/095c8aec7254
Remove blob specialness in image cache. r=tnikkel

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25688 for changes under testing/web-platform/tests

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/095c8aec7254

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Jonathan Watt [:jwatt]]

Seems low risk. Can you request beta uplift or else mark this as status-firefox82:wontfix?

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Given this technically removes an optimization I'd prefer for it to get some bake time, but we should consider uplifting after a week or so if there are no regressions.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Perhaps, see above.

Comment 17

[Jonathan Watt [:jwatt]]

Any decision on this? firefox82:wontfix, or uplift?

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9176261 [details]
Bug 1665343 - Remove blob specialness in image cache. r=tnikkel

Beta/Release Uplift Approval Request

• User impact if declined: Some blob images do not print.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Print https://bug1665343.bmoattachments.org/attachment.cgi?id=9176230
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple patch, removes an optimization that other browsers don't implement.
• String changes made/needed: none

Comment 19

[Julien Cristau [:jcristau]]

Comment on attachment 9176261 [details]
Bug 1665343 - Remove blob specialness in image cache. r=tnikkel

approved for 82.0b8

Comment 20

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/42edb96090a9

Comment 21

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed on82.0.2, 83.0b7 and 84.0a1 with Ubuntu 20.04, macOS 10.15.7 and Windows 10x64.