1665462 - Add Vector::appendAll with move semantics

Status: RESOLVED FIXED

(Core :: MFBT, enhancement)

Description

[Tooru Fujisawa [:arai]]

We have the following:

template <typename T, size_t MinInlineCapacity = 0,
          class AllocPolicy = MallocAllocPolicy>
class MOZ_NON_PARAM Vector final : private AllocPolicy {
...
template <typename U, size_t O, class BP>
  MOZ_MUST_USE bool appendAll(const Vector<U, O, BP>& aU);

that uses copy-semantics, and if T/U doesn't support copy, this doesn't work.

bug 1665387 will require concatenating vectors that contains not-copy-able elements,
and the passed vector doesn't have to be kept after the concatenation.

It would be nice to provide appendAll with move semantics, that moves all elements, and clears the passed vector.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1665462 - Add moving Vector::appendAll(Vector&&) overload. r=jwalden

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1665462 - Use moving Vector::appendAll overload at a few places, or use move assignment. r=jwalden

Depends on D90522

Comment 3

[Jeff Walden [:Waldo]]

Sorry for the delay, I'll get to these either later today or sometime tomorrow.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc6b7d8f4d98
Add moving Vector::appendAll(Vector&&) overload. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/3ba6cafe48d8
Use moving Vector::appendAll overload at a few places, or use move assignment. r=jwalden

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fc6b7d8f4d98
https://hg.mozilla.org/mozilla-central/rev/3ba6cafe48d8